feat: extensions parameter overrides #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
commented
Jan 26, 2024
There was a problem hiding this comment.
The latest pg_cron nixpkg (1.6.2) breaks on PG14, so we pin the version on 1.5.2
There was a problem hiding this comment.
This pinned pg_cron breaks on pg 16 though. I'll change the test to use a contrib extension to avoid these issues.
It no longer exists
soedirgo
force-pushed
the
feat/extensions-parameter-overrides
branch
from
370e2bd
to
8c2fd7a
Compare
For extensions like pg_cron, the permissions depend on the owner of the extension object, which in turn depends on which role runs the `CREATE EXTENSION`. One might want to temporarily make the user role a superuser during pg_restore. This would break pg_cron because once the user role is reverted to non-superuser, the extension owner (i.e. the non-superuser user role) would not have permissions to execute pg_cron functions. This is not an issue if we make the `CREATE EXTENSION` run as the privileged_extensions_superuser unconditionally, since by definition it would always be a superuser.
steve-chavez
approved these changes
Jan 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding
create extensionparameters. E.g. with:When someone runs
create extension pg_cron with schema public, it gets created inpg_cataloginstead:Currently only supports
schema, but may supportversion,owner, etc. in the future.